Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall improvements #15

Open
jonas-eschle opened this issue Mar 31, 2021 · 7 comments
Open

Overall improvements #15

jonas-eschle opened this issue Mar 31, 2021 · 7 comments

Comments

@jonas-eschle
Copy link
Contributor

Since this seems to be a rather old project, it may be worth to completely overhaul such as renaming the methods and package to a more python conform way.

What is your general idea on this?

@madebr
Copy link
Owner

madebr commented Mar 31, 2021

I wholeheartedly agree. The current API is rather old style using python dicts and sometimes feels non-coherent.
A new v2 api would be more then welcomed.

@jonas-eschle
Copy link
Contributor Author

For the next steps, I would propose to change the API and cleanup things. Now the question is a bit overall organisatorial: Is it maybe worth to create an org in order to remove the duty from a single person? The point is that in case you may stop being active, the name in pip and repo cannot be accessed anymore. Or how do you see that?

I would suggest to maybe even create a new package under 'pyopt' (everything small) or maybe a different name not to break the compatibility. Or what do you think? Are you still in contact with the original authors? I guess it would be interesting to know from them as well

Btw can you maybe activate the discussion for the repo? That is better suited for this kind of texts

@madebr
Copy link
Owner

madebr commented Apr 27, 2021

For the next steps, I would propose to change the API and cleanup things. Now the question is a bit overall organisatorial: Is it maybe worth to create an org in order to remove the duty from a single person? The point is that in case you may stop being active, the name in pip and repo cannot be accessed anymore. Or how do you see that?

I don't think pip has a procedure to transfer packages when the original owner stops maintaining.
PIL vs Pillow is a good example for this, I think.
Pillow just supplies the same modules as PIL, but improved.
Same goes for the repo.

But your suggestion to start an organization sounds good.
Do you have a naming suggestion? https://github.com/pyopt is already taken.

I would suggest to maybe even create a new package under 'pyopt' (everything small) or maybe a different name not to break the compatibility. Or what do you think? Are you still in contact with the original authors? I guess it would be interesting to know from them as well

pyopt on pypi is taken as well (https://pypi.org/project/pyopt/)
pyopt2 is not good name as we are an optimization framework, not an argument parsing library.

Btw can you maybe activate the discussion for the repo? That is better suited for this kind of texts

I'll do it right away.

@jonas-eschle
Copy link
Contributor Author

Yes I agree, that is then tricky with the name...
No idea for the org, but I thought we could make it together with cyipopt (mechmotum/cyipopt#95) which is actually a wrapper around ipopt (that is also in pyopt). They have therefore a very similar goal.

@jonas-eschle
Copy link
Contributor Author

Hey @madebr what do you think of 'py-nonlinopt' as the organization name? Is that fine? Then we'll create it and can discuss anything else there

@jonas-eschle
Copy link
Contributor Author

We've created an org, you should have gotten an invite for it. How would you like to proceed, to move the repo there or rather fork from it in the org? Feel free to go about as you wish, you do have full admin rights

@jonas-eschle
Copy link
Contributor Author

ping @madebr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants