You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This happened in my project where if someone has the text block focused and then switches tabs by using a shortcut with the ctrl or metakey (eg ctrl + tab in chrome) and switches back to the Sir Trevor tab by clicking on the tab, Sir Trevor will register the keydown event, but not the keyup event, thus the ctrlDown state in src/block.js stays true and if the next keydown is a command keycode, it will execute that command.
This happened in my project where if someone has the text block focused and then switches tabs by using a shortcut with the ctrl or metakey (eg ctrl + tab in chrome) and switches back to the Sir Trevor tab by clicking on the tab, Sir Trevor will register the
keydown
event, but not thekeyup
event, thus thectrlDown
state insrc/block.js
staystrue
and if the next keydown is a command keycode, it will execute that command.This can be reproduced in the Sir Trevor docs example.
http://madebymany.github.io/sir-trevor-js/example.html
I fixed this in my project by replacing lines
src/block.js:367-383
withShould I open a PR for this?
The text was updated successfully, but these errors were encountered: