Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Sass variable overriding when including stylesheet #530

Closed
martinbean opened this issue Feb 23, 2017 · 0 comments
Closed

Allow for Sass variable overriding when including stylesheet #530

martinbean opened this issue Feb 23, 2017 · 0 comments

Comments

@martinbean
Copy link
Contributor

martinbean commented Feb 23, 2017

I use Bootstrap in a lot of projects. In their _variables.scss file, they suffix each variable value with !default. This means users can include the main Bootstrap style sheet, but define any variables they wish to override beforehand:

$brand-primary: #c00;
$font-family-base: "Ubuntu", sans-serif;

@import "node_modules/bootstrap/scss/bootstrap";

It would be good if the same approach could be taken by Sir Trevor so I can define my custom variable values and then include Sir Trevor’s styles in my application stylesheet:

@import "variables"; // My custom Bootstrap and Sir Trevor variable values

@import "node_modules/bootstrap/scss/bootstrap";
@import "node_modules/sir-trevor/src/sass/main";
ilyatulvio pushed a commit that referenced this issue Feb 27, 2017
Add !default to values; standardise hex values (resolves #530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant