Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste over selected text splits into new block #543

Closed
ToBe998 opened this issue Oct 6, 2017 · 5 comments
Closed

Paste over selected text splits into new block #543

ToBe998 opened this issue Oct 6, 2017 · 5 comments

Comments

@ToBe998
Copy link

ToBe998 commented Oct 6, 2017

If you paste a snippet of text (even only a single word without any formatting) over a selected word within a text block, it will split the text block in three blocks. The one before selection, the pasted text, the part after the selection.

What it should do is just replacing the selected text without changing blocks in any way.

  • Chrome
  • Mac OS
  • Sir-Trevor v0.6.6
@pfinkbeiner
Copy link
Contributor

Hm, I would love to help out but I cant confirm it as a bug. Have you tried to clone the repo and navigate to http://127.0.0.1:8080/examples/ after run npm run dev to ensure its a bug and not some side effects?

@ilyatulvio
Copy link
Contributor

Can't reproduce, might've been fixed since?

@raffij
Copy link
Contributor

raffij commented Mar 4, 2019

Pretty sure it’s valid when you paste in a certain scenario

@raffij
Copy link
Contributor

raffij commented Mar 7, 2019

This was most obvious in firefox.

The issue was when you paste a piece of text it's wrapped in a p tag. Then when scribe inserts that p tag into the block it forces the outer p tag into 3 sequential p tags making 3 blocks.

There's a fix coming in a future release that deals with pasting of sir-trevor block content.

@ToBe998
Copy link
Author

ToBe998 commented Mar 7, 2019

Was also just recently able to reproduce this. Only on Mac/Chrome and Mac/Safari did the

thing. Windows/Chrome was working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants