Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define Jupyter notebooks automatic tests #475

Open
3 tasks
Sinclert opened this issue Jul 30, 2021 · 2 comments
Open
3 tasks

Define Jupyter notebooks automatic tests #475

Sinclert opened this issue Jul 30, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Sinclert
Copy link
Member

This issue describes the need to define a set of tests that run the existing Jupyter notebooks examples to check that changes in the codebase does not leave the examples broken.

These tests can be define by using Papermill, a Python package to execute jupyter notebooks, following what other Python libraries, such as pyhf, has done.

List of goals:

  • Migrate current notebooks to Python3 syntax.
  • Define set of tests using Papermill
  • Include these tests on GitHub Actions (Same trigger conditions as the current CI workflow? different? 🤷🏻‍♂️ )
@Sinclert Sinclert added enhancement New feature or request good first issue Good for newcomers labels Jul 30, 2021
@Sinclert
Copy link
Member Author

Sinclert commented Sep 3, 2021

Notebooks migration PR: #480

@Sinclert
Copy link
Member Author

Sinclert commented Sep 3, 2021

Working-in-progress branch with Papermill tests: https://github.com/diana-hep/madminer/tree/test-jupyter-notebooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sinclert