From be4e421288702d283afb87792effabef4f459811 Mon Sep 17 00:00:00 2001 From: swatijadhav Date: Mon, 8 Dec 2014 23:59:38 +0530 Subject: [PATCH 1/4] fixed required validations for textarea --- addon/mixins/validatable-input.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/addon/mixins/validatable-input.js b/addon/mixins/validatable-input.js index e99c753..35f8b47 100644 --- a/addon/mixins/validatable-input.js +++ b/addon/mixins/validatable-input.js @@ -109,6 +109,13 @@ export default Ember.Mixin.create({ return; } + if(input.tagName.toLowerCase() === 'textarea') { + var content = Ember.$.trim(Ember.$(input).val()); + if(content.length === 0) { + Ember.$(input).val(''); + } + } + if (!input.validity.valid && !input.validity.customError) { this.set('errorMessage', this.getErrorMessage()); } else { From 676fa158e9910f2fdbdfc53322b84eec450c899a Mon Sep 17 00:00:00 2001 From: swatijadhav Date: Tue, 9 Dec 2014 00:17:21 +0530 Subject: [PATCH 2/4] fixed required validations for textarea and text-inputs --- addon/mixins/validatable-input.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/addon/mixins/validatable-input.js b/addon/mixins/validatable-input.js index 35f8b47..4c80ee5 100644 --- a/addon/mixins/validatable-input.js +++ b/addon/mixins/validatable-input.js @@ -109,11 +109,9 @@ export default Ember.Mixin.create({ return; } - if(input.tagName.toLowerCase() === 'textarea') { - var content = Ember.$.trim(Ember.$(input).val()); - if(content.length === 0) { - Ember.$(input).val(''); - } + var content = Ember.$.trim(Ember.$(input).val()); + if(content.length === 0) { + Ember.$(input).val(''); } if (!input.validity.valid && !input.validity.customError) { From 5ac85b24e7fc64ca201b2853f4efc0b5479741dd Mon Sep 17 00:00:00 2001 From: swatijadhav Date: Tue, 9 Dec 2014 00:27:42 +0530 Subject: [PATCH 3/4] reverted: fixed required validations for text-inputs --- addon/mixins/validatable-input.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/addon/mixins/validatable-input.js b/addon/mixins/validatable-input.js index 4c80ee5..35f8b47 100644 --- a/addon/mixins/validatable-input.js +++ b/addon/mixins/validatable-input.js @@ -109,9 +109,11 @@ export default Ember.Mixin.create({ return; } - var content = Ember.$.trim(Ember.$(input).val()); - if(content.length === 0) { - Ember.$(input).val(''); + if(input.tagName.toLowerCase() === 'textarea') { + var content = Ember.$.trim(Ember.$(input).val()); + if(content.length === 0) { + Ember.$(input).val(''); + } } if (!input.validity.valid && !input.validity.customError) { From 4bc717491818aa5ca8ed3b92b8895f11f5bc6e8d Mon Sep 17 00:00:00 2001 From: swatijadhav Date: Tue, 9 Dec 2014 15:14:06 +0530 Subject: [PATCH 4/4] add comments for textarea validation --- addon/mixins/validatable-input.js | 1 + 1 file changed, 1 insertion(+) diff --git a/addon/mixins/validatable-input.js b/addon/mixins/validatable-input.js index 35f8b47..2e8f465 100644 --- a/addon/mixins/validatable-input.js +++ b/addon/mixins/validatable-input.js @@ -109,6 +109,7 @@ export default Ember.Mixin.create({ return; } + // Validate Textarea with proper text and not accept only blank spaces, only new line characters. if(input.tagName.toLowerCase() === 'textarea') { var content = Ember.$.trim(Ember.$(input).val()); if(content.length === 0) {