From d9d8e94fdaf00950c748da2bb92671fb1cb8d74f Mon Sep 17 00:00:00 2001 From: David Lambauer Date: Mon, 7 Nov 2022 22:49:19 +0100 Subject: [PATCH] Added Static Tests Switched to bin/magento execution WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions Replaced tests:run with native phpmd Changed Output Format to GitHub Fixed scope WIP - Working on Github Actions WIP - Working on Github Actions run only for changed files and PRs WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions wip Changed matrix to latest Back to currently-supported as latest doesnt work Used a custom step to get changed files fixed my mess syntax changed action for changed files WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions WIP - Working on Github Actions --- .github/workflows/static-tests.yml | 65 +++++++++++++++++++ .../App/Action/Plugin/Authentication.php | 6 ++ 2 files changed, 71 insertions(+) create mode 100644 .github/workflows/static-tests.yml diff --git a/.github/workflows/static-tests.yml b/.github/workflows/static-tests.yml new file mode 100644 index 000000000000..a9bae65e0a21 --- /dev/null +++ b/.github/workflows/static-tests.yml @@ -0,0 +1,65 @@ +name: Static Magento Tests + +on: + push: + branches: [2.4-develop] + pull_request: + branches: [2.4-develop] + +jobs: + compute_matrix: + name: '🧮 Compute the Matrix' + runs-on: ubuntu-latest + outputs: + matrix: ${{ steps.supported-version.outputs.matrix }} + steps: + - uses: graycoreio/github-actions-magento2/supported-version@main + id: supported-version + with: + kind: latest + - run: echo ${{ steps.supported-version.outputs.matrix }} + + qa: + name: '🤖 - Quality Assurance' + runs-on: ubuntu-latest + needs: compute_matrix + strategy: + fail-fast: false + matrix: ${{ fromJSON(needs.compute_matrix.outputs.matrix) }} + steps: + - uses: actions/checkout@v3 + name: '⬇️ Checkout Code' + + - uses: graycoreio/github-actions-magento2/setup-magento@main + name: '🛠 Setup Magento' + id: setup-magento + with: + php-version: ${{ matrix.php }} + magento_version: ${{ matrix.magento }} + mode: store + coverage: xDebug + + - name: '🚛 Install Dependencies' + run: composer install + working-directory: ${{ steps.setup-magento.outputs.path }} + shell: bash + env: + COMPOSER_CACHE_DIR: ${{ steps.composer-cache.outputs.dir }} + + - name: '👀 Get Changed Files' + uses: jitterbit/get-changed-files@v1 + id: changed-files + with: + format: space-delimited + + - name: '🧠 PHP Mess Detector' + shell: bash + working-directory: ${{ steps.setup-magento.outputs.path }} + run: | + for changed_file in ${{ steps.changed-files.outputs.added_modified }}; do + if [[ $file == *.php ]] + php vendor/bin/phpmd ${changed_file} github dev/tests/static/testsuite/Magento/Test/Php/_files/phpmd/ruleset.xml + else + echo "Skip for file: ${changed_file}" + fi + done diff --git a/app/code/Magento/AdminAdobeIms/App/Action/Plugin/Authentication.php b/app/code/Magento/AdminAdobeIms/App/Action/Plugin/Authentication.php index 845b908d7524..e4b8bb851def 100644 --- a/app/code/Magento/AdminAdobeIms/App/Action/Plugin/Authentication.php +++ b/app/code/Magento/AdminAdobeIms/App/Action/Plugin/Authentication.php @@ -56,4 +56,10 @@ public function __construct( $this->_openActions[] = ImsCallback::ACTION_NAME; } + + private function unusedMethod() + { + + return 'unused'; + } }