Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support text messages #131

Open
piegamesde opened this issue Oct 2, 2021 · 2 comments
Open

Support text messages #131

piegamesde opened this issue Oct 2, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@piegamesde
Copy link
Member

piegamesde commented Oct 2, 2021

The protocol level on that one is rather easy. Implementation notes:

  • Sender side:
    • Add a --text file to the send command (alternatively, have a send-text command?)
    • If the file to be sent is -, the content from stdin is sent as text message. Interactive prompts are disabled (though I don't think we have any at the moment).
    • Don't forget to limit the input size to something sensible.
  • Receiver side:
    • Text messages are always accepted by default
    • Do some quick content type checking and maybe display binary files differently
    • Maybe filter terminal escape codes? (Also maybe sending colored text is a feature, but are there any security risks?)
    • Check text size again before printing (maybe automatically open $PAGER with the content on long messages?)
    • Add CLI flag to write the message to a file instead (optional IMO)
@piegamesde piegamesde added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 2, 2021
@felinira
Copy link
Collaborator

I would be interested in being able to receive text messages that were sent from the python client. Once in a while someone tries this and is presented with an unhelpful error message. This would probably be easiest to implement on top of the transfer-v2 API change once that is done, right?

Downstream issue: https://gitlab.gnome.org/World/warp/-/issues/30

@j-lakeman
Copy link

Any updates on this?
This feature would be really handy IMHO to send secrets e.g. passwords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants