Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Error reporting: Pass through Mailchimp errors to FE #90

Open
1 task done
MaxwellGarceau opened this issue Dec 24, 2024 · 0 comments
Open
1 task done

Better Error reporting: Pass through Mailchimp errors to FE #90

MaxwellGarceau opened this issue Dec 24, 2024 · 0 comments
Labels
type:enhancement New feature or request.

Comments

@MaxwellGarceau
Copy link
Collaborator

MaxwellGarceau commented Dec 24, 2024

Is your enhancement related to a problem? Please describe.

Problem

Currently, Mailchimp errors will not be displayed on the FE. It is assumed that if a request is not a 200 response and there are no errors in the body that the email address is invalid.

However, I ran into a 400 error while testing because "[email protected] has signed up to a lot of lists very recently; we're not allowing more signups for now".

This error was not visible on the FE. If a user ran into a different 4** error related to Mailchimp anti-spam (or another limit) it would be a bad user experience.

Response from Mailchimp API

Summarized_Log_Entry.txt
Raw_Log_Output.txt

Solution

Admin View (could also show a logged out user)

  • Update the error message check to also check for $body['detail'] and display the detail property as an error message if exists.
  • Double check Mailchimp API docs to ensure that error messages are not transmitted via another property on the response

User View

  • Give a generalized error message that lets a user know their subscription was not successful.
    • Maybe pull in the contact information from Settings > General > Administration Email Address?

Designs

No response

Describe alternatives you've considered

Another solution would be to generalize the catch all email validation. For example, "Email Address: Please fill out a valid email address, choose another email address, or wait a little bit before your next submission".

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MaxwellGarceau MaxwellGarceau added the type:enhancement New feature or request. label Dec 24, 2024
@jeffpaul jeffpaul added this to the Future Release milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants