Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on page /svm_decoding.html #37

Open
Andjelaaaa opened this issue May 16, 2023 · 5 comments
Open

Issue on page /svm_decoding.html #37

Andjelaaaa opened this issue May 16, 2023 · 5 comments

Comments

@Andjelaaaa
Copy link

Hi, at the last step where the accuracy is printed for the Fast Regularized Ensembles of models (frem) as follows:
print('F1 scoreswith FREM') for category in categories: print(category, '\t\t {:.2f}'.format(np.mean(decoder.cv_scores_[category])))
Shouldn't it be averaged using frem scores instead of the ones from the decoder model? Hence, it would be:
print('F1 scoreswith FREM') for category in categories: print(category, '\t\t {:.2f}'.format(np.mean(frem.cv_scores_[category])))

@PeerHerholz
Copy link
Collaborator

Hi @Andjelaaaa,

thank you very much for opening this issue and pointing this out.

I think you are correct. Just checking with @bthirion who prepared and presented this part: that's a typo, right?

Thx again.

Cheers, Peer

@bthirion
Copy link
Contributor

You're absolutely right ! Sorry for the mistake

@PeerHerholz
Copy link
Collaborator

Thx for the reply @bthirion and no worries at all!

@Andjelaaaa would you be up for submitting a small PR to fix this? Otherwise, I can do it as well.

@pbellec
Copy link
Contributor

pbellec commented Oct 18, 2024

was that fixed in the last update @PeerHerholz ?

@PeerHerholz
Copy link
Collaborator

Yes, this was updated and fixed in the respective section via #43 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants