Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(6) Consider changing comment about ES #15

Open
oldchili opened this issue Jan 8, 2024 · 2 comments
Open

(6) Consider changing comment about ES #15

oldchili opened this issue Jan 8, 2024 · 2 comments

Comments

@oldchili
Copy link
Contributor

oldchili commented Jan 8, 2024

// Cancel an auction during ES or via governance action.
- Since we do a slip instead of a flux end.snip's grab call will fail. So not sure if we can leave the mention of ES here (and there's a question whether we rely the end or not).

@sunbreak1211
Copy link
Collaborator

sunbreak1211 commented Jan 9, 2024

This is a good question, and the subject is probably much deeper as today we do not have any mechanism to exit the real MKR that will be shared via the End module in the form of vat.gem. Also grabbing the vault is an issue per se as well as the oracle will be the sticky one, you want the real price instead of that one at the moment you need to cage the ilk.

@sunbreak1211
Copy link
Collaborator

Fix for this: #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants