Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blocking dependency on etherscan #31

Open
8 tasks
SidestreamColdMelon opened this issue Jun 3, 2024 · 1 comment
Open
8 tasks

Remove blocking dependency on etherscan #31

SidestreamColdMelon opened this issue Jun 3, 2024 · 1 comment
Assignees

Comments

@SidestreamColdMelon
Copy link
Contributor

Goal

Spell process is not blocked in case etherscan is down/not available

Context

As per the parent issue #29, currently there are multiple places in process which refer to etherscan as place to check something. But as etherscan is a centralised tool, we have to expect a possibility that 1) it is down 2) it is compromised and prepare accordingly.

Places where we refer to etherscan

Proposed circumvention

Use multiple different services to verify the source code.

Tasks

  • Extend the verification script
    • Send flattened code to multiple services (potentially using forge verify-contract instead of making raw requests)
    • Ensure requests to services are non-blocking (in case one service is down)
  • Editing checklists
    • Replace "etherscan" with "at least 2 trusted block scanners"
    • Define/refer to a "list of trusted blocks canners" (used by the verification script)
    • Get priority fee from a more decentralised source (or otherwise make it a recommendation)
  • Replace or remove automatic check of the source code
@0x3phemeralsoul
Copy link
Contributor

it should verify on:
Etherscan
Sourcify
Blockscout

This ticket should also update the checklist to include 2 out 3 verified sources from the above. Spell should always be verified in 2 sources at least, normally on the 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants