Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions thrown by on_block don't even get logged #49

Open
ghost opened this issue Nov 20, 2017 · 0 comments
Open

Exceptions thrown by on_block don't even get logged #49

ghost opened this issue Nov 20, 2017 · 0 comments

Comments

@ghost
Copy link

ghost commented Nov 20, 2017

Exceptions thrown during execution of the on_block handler don't even get properly logged, they are just being output to stdout/stderr(?).

I would recommend logging them, and also thinking about what should actually happen when an exception occurs. It happens every now and then that the parity/geth rpc doesn't respond in time, but I don't think it should be a reason for the keeper to terminate... I am personally against it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants