Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Typo in 01_pytorch_computation_graph.ipynb - Example Code Explain Error” #12

Open
sjin4861 opened this issue Oct 4, 2024 · 0 comments

Comments

@sjin4861
Copy link

sjin4861 commented Oct 4, 2024

I noticed a typo in the manual calculation section of the notebook 01_pytorch_computation_graph.ipynb under the Manually check PyTorch Result section.

dz/da = dz/dx * dx/da + dz/dy * dy/da

  = 2 * 2 + 3 * 10a

  = 4  + 30a

When a = 3.5, dz/da = 64 ... correct!

However, the correct value of a should be a = 2.0 instead of a = 3.5 to match the context of the earlier examples in the notebook.

The corrected section should look like this:

dz/da = dz/dx * dx/da + dz/dy * dy/da

  = 2 * 2 + 3 * 10a

  = 4  + 30a

When a = 2.0, dz/da = 64 ... correct!

Please update the notebook to reflect this correction. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant