Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong orientation after conversion #11

Open
mbirth opened this issue Nov 8, 2020 · 2 comments
Open

Wrong orientation after conversion #11

mbirth opened this issue Nov 8, 2020 · 2 comments

Comments

@mbirth
Copy link

mbirth commented Nov 8, 2020

After converting the attached photo, it turns from portrait to landscape.

IMG_20200621_1745383.jpg.zip

P.S.: Are there really no quality settings for the conversion?

@fbzhong
Copy link

fbzhong commented Nov 22, 2020

@mbirth there is no quality settings in this app, but you could use the following snippets to adjust it:

            let options = [kCGImageDestinationLossyCompressionQuality: 9.0]
            CGImageDestinationAddImageAndMetadata(destination, image, imageMetadata, options as CFDictionary)

@makoni
Copy link
Owner

makoni commented Dec 11, 2020

Hi. I tried your file and have the same issue. For some reason during copying metadata during conversion orientation value resets. There's no manual code for changing metadata, everything happens on macOS side so probably it's a macOS bug.

If anyone knows how to fix it - PR is welcome.

For quality settings there's new slider in new version: https://github.com/makoni/jpg-to-heif-converter/releases/tag/1.06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants