Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better PDF/CBR/CBZ/EPUB generation ? #460

Open
MikeZeDev opened this issue Jan 11, 2024 · 7 comments
Open

Better PDF/CBR/CBZ/EPUB generation ? #460

MikeZeDev opened this issue Jan 11, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@MikeZeDev
Copy link
Contributor

  1. Begin able to generate PDF for VOLUMES and not CHAPTERS.

Ofc we aint gonna guess which chapters for which volume. User select downloaded chapters from the UI, right click, generate => PDF.

  1. Afaik PDFKIT library is NOT able to handle WEBP. Find a PDF library that we can integrate AND being able to deal with WEBP, or convert WEBP before processing?
@MikeZeDev MikeZeDev added the enhancement New feature or request label Jan 11, 2024
@Sheepux
Copy link
Contributor

Sheepux commented Jan 11, 2024

Split this enhancement request in 2 separate ones:

  1. "Merge downloads together" ( volume or ....)
  2. Better pdf library

@MikeZeDev
Copy link
Contributor Author

Note : good old PDFKit got the problem with PNG + it cant handle WEBP, which are major problems.

@ronny1982
Copy link
Contributor

To the best of my knowledge the latest version of PDF specs (2020) does still not include support for WebP, therefore it has to be converted to PNG/JPEG.

@Murshid7absi
Copy link

maybe this can help for PDF libraries: https://byby.dev/js-pdf-libs

@Sheepux
Copy link
Contributor

Sheepux commented Feb 23, 2024

maybe this can help for PDF libraries: https://byby.dev/js-pdf-libs

this doesn't solve the volume (it's not related to the pdf lib but to the way we decide to put content in it).
this doesn't solve the webp issue as it's a pdf issue

@Murshid7absi
Copy link

Murshid7absi commented Jun 18, 2024

you can use Pillow library to convert from various image formats. Then use ReportLab or PyMuPDF to create the pdf which also support various formats including WEBP if Pillow doesn't work for you.

Edit: now I see that I suggested a solution for python not typescript. but if you can integrate it maybe it will help idk

@ronny1982
Copy link
Contributor

ronny1982 commented Sep 7, 2024

See: 2c3f5a7#diff-694ec51ee160ab7e75fb3ed61f3d78d958e3d09a1788c1731a149f13b3c3fa31

Merging multiple chapters would be a massive effort since existing PDF, EPUB, CBZ needs a mechanism to integrate new images into the existing containers while dealing with the correct order.
Furthermore it would be quite difficult to track chapters that have already been downloaded by just looking at the images of such container formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants