Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve button gradient borders #114

Open
manniL opened this issue Oct 13, 2023 · 2 comments
Open

Improve button gradient borders #114

manniL opened this issue Oct 13, 2023 · 2 comments
Labels
hacktoberfest help wanted

Comments

@manniL
Copy link
Owner

manniL commented Oct 13, 2023

Right now, they need extra elements. According to this post, it also works without. Would be a nice improvement 👍🏻
@kisharnath
Copy link
Contributor

Can you elaborate this problem more

@manniL
Copy link
Owner Author

manniL commented Jan 1, 2024

@kisharnath Sure! If you take a look at the AppButton component, you see that multiple elements (3 spans) are existent. The linked tweet shows, that only one might be necessary with a bit of CSS magic.

@manniL manniL linked a pull request Feb 11, 2024 that will close this issue
Changes made for button #125
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes made for button kisharnath/lichter.io
2 participants
@manniL @kisharnath