Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all files cleaned up with EXTRA=1 #99

Closed
5 tasks
donhardman opened this issue Dec 6, 2024 · 1 comment
Closed
5 tasks

Not all files cleaned up with EXTRA=1 #99

donhardman opened this issue Dec 6, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@donhardman
Copy link
Contributor

donhardman commented Dec 6, 2024

Bug Description:

We have an issue when we run a Docker container from our official image with the EXTRA=1 flag, and some files are not cleaned up after installation. We should clean them up because it's useless to keep them inside the container.

MRE

Run the latest image:

docker run --env EXTRA=1 --name mre -it --rm manticoresearch/manticore:dev-6.3.9-a71989f

Investigate what is inside after all is done:

~  docker exec -it mre bash
root@2214c1cedb7d:/var/lib/manticore# ls -lt .extra/
total 112332
-rwxr-xr-x 1 manticore manticore 74910048 Dec  6 05:00 manticore-executor
-rw-r--r-- 1 manticore manticore      488 Dec  6 05:00 _gpgorigin
-rw-r--r-- 1 manticore manticore 20045388 Dec  6 05:00 data.tar.xz
-rw-r--r-- 1 manticore manticore      608 Dec  6 05:00 control.tar.xz
-rw-r--r-- 1 manticore manticore        4 Dec  6 05:00 debian-binary
-rw-r--r-- 1 manticore manticore 20046736 Nov 24 09:18 manticore-executor_1.2.1-24112407-aedd870_arm64.deb
drwxr-xr-x 3 manticore manticore     4096 Nov 24 09:08 usr
root@2214c1cedb7d:/var/lib/manticore# ls -lt /tmp/
total 8
drwxr-xr-x 3 manticore manticore 4096 Dec  6 05:00 galera
drwxr-xr-x 3 manticore manticore 4096 Dec  6 05:00 columnar
root@2214c1cedb7d:/var/lib/manticore# du -sh /tmp
16M	/tmp
root@2214c1cedb7d:/var/lib/manticore# du -sh .extra
182M	.extra
root@2214c1cedb7d:/var/lib/manticore#

Docker image version:

Latest dev version

Have you tried the latest development version?

None

Internal Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation reviewed
  • Changelog updated
@donhardman donhardman added the bug Something isn't working label Dec 6, 2024
djklim87 pushed a commit that referenced this issue Dec 9, 2024
djklim87 added a commit that referenced this issue Dec 9, 2024
@djklim87
Copy link
Collaborator

djklim87 commented Dec 9, 2024

Done in #100

@djklim87 djklim87 closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants