Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 8.4 #228

Open
Nick-S-2018 opened this issue Dec 17, 2024 · 3 comments
Open

Support for PHP 8.4 #228

Nick-S-2018 opened this issue Dec 17, 2024 · 3 comments
Assignees

Comments

@Nick-S-2018
Copy link
Collaborator

We need to test the client with PHP 8.4 to make sure everything works fine.

@sanikolaev
Copy link
Collaborator

For now if it's not supported let's mention it in the support matrix in https://github.com/manticoresoftware/manticoresearch-php/blob/master/README.md

@CicerBro
Copy link

This is holding back my 8.4 upgrade. Would be nice to have this work.

Currently running into errors like:

   DEPRECATED  Manticoresearch\Client::__construct(): Implicitly marking parameter $logger as nullable is deprecated, the explicit nullable type must be used instead in vendor/manticoresoftware/manticoresearch-php/src/Manticoresearch/Client.php on line 63.


   DEPRECATED  Manticoresearch\Client::index(): Implicitly marking parameter $name as nullable is deprecated, the explicit nullable type must be used instead in vendor/manticoresoftware/manticoresearch-php/src/Manticoresearch/Client.php on line 304.


   DEPRECATED  Manticoresearch\Transport::__construct(): Implicitly marking parameter $connection as nullable is deprecated, the explicit nullable type must be used instead in vendor/manticoresoftware/manticoresearch-php/src/Manticoresearch/Transport.php on line 34.


   DEPRECATED  Manticoresearch\Transport::__construct(): Implicitly marking parameter $logger as nullable is deprecated, the explicit nullable type must be used instead in vendor/manticoresoftware/manticoresearch-php/src/Manticoresearch/Transport.php on line 34.


   DEPRECATED  Manticoresearch\Transport\Http::__construct(): Implicitly marking parameter $connection as nullable is deprecated, the explicit nullable type must be used instead in vendor/manticoresoftware/manticoresearch-php/src/Manticoresearch/Transport/Http.php on line 35.


   DEPRECATED  Manticoresearch\Transport\Http::__construct(): Implicitly marking parameter $logger as nullable is deprecated, the explicit nullable type must be used instead in vendor/manticoresoftware/manticoresearch-php/src/Manticoresearch/Transport/Http.php on line 35.

@sanikolaev
Copy link
Collaborator

@CicerBro would you like to make a PR which adapts the code to PHP 8.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants