-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize expressions #20
Labels
Comments
Anyone planning on working on this? |
I have forked and made an improved version. |
@coocy that's great, are you interested in putting together a PR? I can help review it. |
@andrewharvey OK, I'll do this later. |
@coocy Do you still plan doing that? Maybe you can use some help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
adaptPropertyLanguage()
should attempt to localize expressions used astext-field
s. Currently, it only works for constant strings and style functions.mapbox/mapbox-gl-js#6197 is a proposal to make label localization a built-in feature of the style specification. In the meantime, mapbox/mapbox-gl-native#11651 has a comprehensive implementation of label localization in Objective-C. While that implementation targets NSExpression’s syntax, the same logic should more or less apply when working with style JSON objects.
/cc @lukasmartinelli @tristen @anandthakker
The text was updated successfully, but these errors were encountered: