You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The original vision behind mapbox/mapbox-directions-swift#391 was that a client such as the navigation SDK would operate mostly in terms of a whole RouteResponse plus a route index into that response. That way, we don’t have to copy attributes of the response into each individual route, as seen in mapbox/mapbox-directions-swift#452. Unfortunately, we never got quite that far in #2350:
MapboxNavigationService(route:routeOptions:directions:locationSource:eventsManagerType:simulating:routerType:) should take a RouteResponse, not an individual Route.
NavigationViewController(for:routeOptions:navigationOptions:) should take a NavigationService instead of a Route.
This much sounds simple, but there are potentially quite a few knock-on effects throughout the codebase. It’s too late to get these backwards-incompatible changes into v1.0. We can get them into a subsequent minor release as long as we take steps to ensure backwards compatibility. A convenience initializer for MapboxNavigationService can wrap a Route in a RouteResponse, and a convenience initializer for NavigationViewController can wrap a Route in a RouteResponse and MapboxNavigationService.
/cc @mapbox/navigation-ios
The text was updated successfully, but these errors were encountered:
1ec5
added
the
op-ex
Refactoring, Tech Debt or any other operational excellence work.
label
Sep 2, 2020
The original vision behind mapbox/mapbox-directions-swift#391 was that a client such as the navigation SDK would operate mostly in terms of a whole RouteResponse plus a route index into that response. That way, we don’t have to copy attributes of the response into each individual route, as seen in mapbox/mapbox-directions-swift#452. Unfortunately, we never got quite that far in #2350:
MapboxNavigationService(route:routeOptions:directions:locationSource:eventsManagerType:simulating:routerType:)
should take a RouteResponse, not an individual Route.NavigationViewController(for:routeOptions:navigationOptions:)
should take a NavigationService instead of a Route.This much sounds simple, but there are potentially quite a few knock-on effects throughout the codebase. It’s too late to get these backwards-incompatible changes into v1.0. We can get them into a subsequent minor release as long as we take steps to ensure backwards compatibility. A convenience initializer for MapboxNavigationService can wrap a Route in a RouteResponse, and a convenience initializer for NavigationViewController can wrap a Route in a RouteResponse and MapboxNavigationService.
/cc @mapbox/navigation-ios
The text was updated successfully, but these errors were encountered: