Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include a literal ~ in PATH #17

Open
jfirebaugh opened this issue Mar 28, 2018 · 0 comments
Open

Don't include a literal ~ in PATH #17

jfirebaugh opened this issue Mar 28, 2018 · 0 comments

Comments

@jfirebaugh
Copy link
Contributor

The literal ~ here is problematic:

mbgl-ci-images/base/Dockerfile

Line 38 in 7d2403f

PATH="/usr/lib/ccache:~/.yarn/bin:$PATH"

  • It causes which yarn to fail, even though (in bash), yarn itself will work.
  • It causes yarn not to work at all in /bin/sh, due to some obscure difference between sh and bash as to when tilde expansion takes place.

It should be replaced with $HOME or /root.
anandthakker pushed a commit to mapbox/mapbox-gl-js that referenced this issue May 1, 2018
Workaround CI image path bash/sh issue
b8c34aa 
mapbox/mbgl-ci-images#17
@anandthakker anandthakker mentioned this issue May 1, 2018
Merged
anandthakker added a commit to mapbox/mapbox-gl-js that referenced this issue May 1, 2018
@anandthakker
Ensure style-spec is published with mapbox-gl (#6586)
478dd56 
* Ensure style spec is published with build

Closes #6433
Closes #6574

* Consolidate build unit test commands

* Workaround CI image path bash/sh issue

mapbox/mbgl-ci-images#17
anandthakker added a commit to mapbox/mapbox-gl-js that referenced this issue May 3, 2018
@anandthakker
Ensure style-spec is published with mapbox-gl (#6586)
d358246 
Cherry pick 478dd56 from master

* Ensure style spec is published with build

Closes #6433
Closes #6574

* Consolidate build unit test commands

* Workaround CI image path bash/sh issue

mapbox/mbgl-ci-images#17
anandthakker added a commit to mapbox/mapbox-gl-js that referenced this issue May 3, 2018
@anandthakker
Cherry pick style-spec build fixes from master (#6603)
3bd1803 
* Fix style-spec build (#6575)

* Ensure style-spec is published with mapbox-gl (#6586)

Cherry pick 478dd56 from master

* Ensure style spec is published with build

Closes #6433
Closes #6574

* Consolidate build unit test commands

* Workaround CI image path bash/sh issue

mapbox/mbgl-ci-images#17

* Bump style-spec version to 12.0.0-pre.1 (#6595)

* Use named exports in style-spec.js (#6602)

Cherry pick e83054f from master

Fixes #6601

* Ignore whole /dist/ directory

Done in master with e83054f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfirebaugh