Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize pbf_reader::get_packed_bool #34

Open
joto opened this issue Nov 11, 2015 · 2 comments
Open

Optimize pbf_reader::get_packed_bool #34

joto opened this issue Nov 11, 2015 · 2 comments
Labels
enhancement

Comments

@joto
Copy link
Collaborator

joto commented Nov 11, 2015

pbf_reader::get_packed_bool() currently calls get_packed_int32(). But with a one-byte bool there will never be any endianness or alignment issues so we could optimize this case.
@springmeyer
Copy link
Contributor

Has this show up in profiling for you on certain types of messages @joto?

@joto
Copy link
Collaborator Author

joto commented May 11, 2016

No. This is more theoretical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@springmeyer @joto