Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Function taking string as input, retrieves the BBox for that #25

Open
Rubix982 opened this issue Jun 24, 2021 · 3 comments
Open
Assignees
Labels
feature A feature request for the SDK

Comments

@Rubix982
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It's not always feasible for humans to know the coordinates of a location. Numbers are already harder to remember, more so longer floating values like coordinates, and it can be annoying for users to go and handpick the coordinates. However, it is very easy to remember the names of locations, e.g., 'Cairo, Egypt'.

This function will return a bounding box of that location, which can then be fed into the API for the Mapillary Python SDK, for which results can be returned as desired.

Describe the solution you'd like
Some function that does all the underlying location -> coordinates logic at the low level. Either we make a utility function that users can use, or we make something as simple as the solution that osmnx suggests, which is just taking in a string, and outputting some results for that, not bothering users deal with the numerical logic as well

Describe alternatives you've considered
NA

Additional context
This idea was slightly discussed in the 1st Maintainer Meeting on the 24th of June

@Rubix982 Rubix982 added the feature A feature request for the SDK label Jun 24, 2021
@Rubix982 Rubix982 changed the title [Feature] Implementing a function that takes a string as an input, and retrieves the bounding box for that [Feature] Function taking string as input, retrieves the BBox for that Jun 24, 2021
@Rubix982
Copy link
Contributor Author

Blocker

Since we are moving forward on Bounding Box aspect, I was looking around to solve this issue, and I found this library, GeoCoder. It provides an abstraction on top of Google APIs and Bing APIs for GeoSpatial data, but it needs an API key of its own.

I looked at Mapbox's API for Forward and Reverse GeoCoding, it also needs an API key.

@cbeddow
Copy link
Member

cbeddow commented Jul 20, 2021

It sounds like the way to go here is to make OSMnx a dependency to be able to use the functions here? https://github.com/gboeing/osmnx/blob/main/osmnx/geocoder.py

@Rubix982
Copy link
Contributor Author

I mentioned osmnx somewhere - but forgot to add here. Thanks for the headsup, @cbeddow!

@Rubix982 Rubix982 self-assigned this Jul 20, 2021
Rubix982 added a commit that referenced this issue Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A feature request for the SDK
Projects
None yet
Development

No branches or pull requests

2 participants