Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would it make sense to have binary releases on github? #2

Open
jhutar opened this issue Jan 7, 2021 · 4 comments · May be fixed by #3
Open

would it make sense to have binary releases on github? #2

jhutar opened this issue Jan 7, 2021 · 4 comments · May be fixed by #3

Comments

@jhutar
Copy link

jhutar commented Jan 7, 2021

Hello. Would you accept a build script like:

https://github.com/oliver006/redis_exporter/blob/master/release-github-binaries.sh

I now anything about go, but I should be able to modify that script quite easily, because I think it would be handy to have pre-compiled binaries available.

@marckhouzam
Copy link
Owner

Thanks for the suggestion @jhutar ! I haven't had time recently for this project but I agree it would be nice to have a release.

In the mean time you can maybe use the docker image?
https://hub.docker.com/repository/docker/marckhouzam/custom-prometheus-exporter

@jhutar
Copy link
Author

jhutar commented Jan 25, 2021

Hello. I do not have an immediate issue - we built the exporter and it just works. Would you be OK if I attempt to submit a PR with a script as above?

@marckhouzam
Copy link
Owner

Yes of course! But I cannot promise when I'll have time to look at it, but I'll try.

@jhutar jhutar linked a pull request Jan 26, 2021 that will close this issue
@jhutar
Copy link
Author

jhutar commented Jan 26, 2021

Sure, no problem. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants