Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

% sign in password should be escaped #5

Open
glebteterin opened this issue Jan 13, 2022 · 1 comment
Open

% sign in password should be escaped #5

glebteterin opened this issue Jan 13, 2022 · 1 comment

Comments

@glebteterin
Copy link

When password contains % sign, it has to be escaped with %%. Otherwise you will get 530 Login authentication failed error.

It happens because commands are pre-formatted before sending them to textproto.Cmd. As a result, the command text is being used as a format parameter without arguments, so that the password "a%b" will turn to "a%!b(MISSING)"

@marcobeierer
Copy link
Owner

@glebteterin Thank you for reporting the issue.

I have no time to fix the issue currently, but am open for pull requests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants