Oppositive semigroup #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
marcosh
commented
Sep 27, 2023
marcosh
commented
- introduce opposite semigroup
- do not flip arguments in list concatenation monoid
drupol
reviewed
Sep 27, 2023
| @@ -29,6 +29,6 @@ public function mempty(): array | |||
| */ | |||
| public function append($a, $b) | |||
| { | |||
| return array_merge($b, $a); | |||
| return array_merge($a, $b); | |||
There was a problem hiding this comment.
yes, it is. I'll write an ADR for this.
Keeping the arguments in the same order is just more natural.
Otherwise append(['a'], ['b']) would be ['b', 'a'], while it is more expected to be ['a', 'b'].
Do you agree?
There was a problem hiding this comment.
Yes, definitely ! Thanks for the explanation :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.