From caead40bface9eaeea567cc76b504f41c07eb6ef Mon Sep 17 00:00:00 2001
From: OsamaAbdellateef <osama.abd9888@gmail.com>
Date: Wed, 17 Jan 2024 19:18:49 +0200
Subject: [PATCH 1/3] Adding onClear prop to Autocomplete Component

---
 packages/components/src/Autocomplete/Autocomplete.tsx | 11 ++++++++---
 packages/components/src/Autocomplete/ClearButton.tsx  | 11 +++++++++--
 2 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/packages/components/src/Autocomplete/Autocomplete.tsx b/packages/components/src/Autocomplete/Autocomplete.tsx
index c894f2a72c..51864373ae 100644
--- a/packages/components/src/Autocomplete/Autocomplete.tsx
+++ b/packages/components/src/Autocomplete/Autocomplete.tsx
@@ -18,9 +18,10 @@ import { AutocompleteClearButton } from './ClearButton';
 //----------------
 interface SearchInputProps {
   onSubmit?: (key: Key | null, value: string | null) => void;
+  onClear?: () => void;
   ref?: Ref<HTMLInputElement> | undefined;
 }
-const SearchInput = ({ onSubmit, ref }: SearchInputProps) => {
+const SearchInput = ({ onSubmit, onClear, ref }: SearchInputProps) => {
   const state = React.useContext(ComboBoxStateContext);
 
   return (
@@ -28,7 +29,9 @@ const SearchInput = ({ onSubmit, ref }: SearchInputProps) => {
       ref={ref}
       icon={<SearchIcon />}
       action={
-        state?.inputValue !== '' ? <AutocompleteClearButton /> : undefined
+        state?.inputValue !== '' ? (
+          <AutocompleteClearButton onClear={onClear} />
+        ) : undefined
       }
       onKeyDown={e => {
         if (e.key === 'Enter' || e.key === 'Escape') {
@@ -81,6 +84,7 @@ export interface AutocompleteProps
   defaultValue?: RAC.ComboBoxProps<object>['defaultInputValue'];
   value?: RAC.ComboBoxProps<object>['inputValue'];
   onChange?: RAC.ComboBoxProps<object>['onInputChange'];
+  onClear?: () => void;
   disabled?: RAC.ComboBoxProps<object>['isDisabled'];
   required?: RAC.ComboBoxProps<object>['isRequired'];
   error?: RAC.ComboBoxProps<object>['isInvalid'];
@@ -113,6 +117,7 @@ const _Autocomplete = forwardRef<HTMLInputElement, AutocompleteProps>(
       defaultValue,
       value,
       onChange,
+      onClear,
       onSubmit,
       disabled,
       error,
@@ -138,7 +143,7 @@ const _Autocomplete = forwardRef<HTMLInputElement, AutocompleteProps>(
     return (
       <>
         <FieldBase as={ComboBox} {...props}>
-          <SearchInput onSubmit={onSubmit} ref={ref} />
+          <SearchInput onSubmit={onSubmit} onClear={onClear} ref={ref} />
           <Popover>
             <ListBox>{children}</ListBox>
           </Popover>
diff --git a/packages/components/src/Autocomplete/ClearButton.tsx b/packages/components/src/Autocomplete/ClearButton.tsx
index c808076f15..1e2e592971 100644
--- a/packages/components/src/Autocomplete/ClearButton.tsx
+++ b/packages/components/src/Autocomplete/ClearButton.tsx
@@ -7,16 +7,23 @@ import { Button } from '../Button';
 
 export interface ClearButtonProps {
   className?: string;
+  onClear?: () => void;
 }
 
-export const AutocompleteClearButton = ({ className }: ClearButtonProps) => {
+export const AutocompleteClearButton = ({
+  className,
+  onClear,
+}: ClearButtonProps) => {
   let state = React.useContext(ComboBoxStateContext);
 
   return (
     <Button
       // Don't inherit default Button behavior from ComboBox.
       aria-label="Clear"
-      onPress={() => state?.setInputValue('')}
+      onPress={() => {
+        state?.setInputValue('');
+        onClear?.();
+      }}
       variant="icon"
       className={cn(
         'cursor-pointer appearance-none border-none p-0 pr-1',

From 3246b4040f8f7bf80b3065fc40c0e6a084ce382f Mon Sep 17 00:00:00 2001
From: OsamaAbdellateef <osama.abd9888@gmail.com>
Date: Wed, 17 Jan 2024 19:22:47 +0200
Subject: [PATCH 2/3] adding changeset

---
 .changeset/tender-radios-begin.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/tender-radios-begin.md

diff --git a/.changeset/tender-radios-begin.md b/.changeset/tender-radios-begin.md
new file mode 100644
index 0000000000..690a416225
--- /dev/null
+++ b/.changeset/tender-radios-begin.md
@@ -0,0 +1,5 @@
+---
+"@marigold/components": patch
+---
+
+Adding onClear prop over Autocomplete component

From 16ff82415bb41e59291337cd12aa48d784022dac Mon Sep 17 00:00:00 2001
From: OsamaAbdellateef <osama.abd9888@gmail.com>
Date: Thu, 18 Jan 2024 11:31:21 +0200
Subject: [PATCH 3/3] Cover tests

---
 .../src/Autocomplete/Autocomplete.test.tsx    | 19 +++++++++++++++++++
 .../src/Autocomplete/ClearButton.tsx          |  1 +
 2 files changed, 20 insertions(+)

diff --git a/packages/components/src/Autocomplete/Autocomplete.test.tsx b/packages/components/src/Autocomplete/Autocomplete.test.tsx
index ef8ce9323f..b667005565 100644
--- a/packages/components/src/Autocomplete/Autocomplete.test.tsx
+++ b/packages/components/src/Autocomplete/Autocomplete.test.tsx
@@ -360,6 +360,25 @@ test('supports autocompletion', async () => {
   expect(input).toHaveValue('Spinach');
 });
 
+test('supports clear input value', async () => {
+  render(
+    <Autocomplete label="Label" data-testid="input-field">
+      <Autocomplete.Item id="spinach">Spinach</Autocomplete.Item>
+      <Autocomplete.Item id="carrots">Carrots</Autocomplete.Item>
+      <Autocomplete.Item id="broccoli">Broccoli</Autocomplete.Item>
+      <Autocomplete.Item id="garlic">Garlic</Autocomplete.Item>
+    </Autocomplete>
+  );
+
+  const input = screen.getByRole('combobox');
+  await user.type(input, 'sp');
+
+  const clearButton = screen.getByTestId('clear-button');
+  expect(clearButton).toBeInTheDocument();
+  await user.click(clearButton);
+  expect(input).toHaveValue('');
+});
+
 test('supports submit handler', async () => {
   const spy = jest.fn();
 
diff --git a/packages/components/src/Autocomplete/ClearButton.tsx b/packages/components/src/Autocomplete/ClearButton.tsx
index 1e2e592971..c521e2e953 100644
--- a/packages/components/src/Autocomplete/ClearButton.tsx
+++ b/packages/components/src/Autocomplete/ClearButton.tsx
@@ -20,6 +20,7 @@ export const AutocompleteClearButton = ({
     <Button
       // Don't inherit default Button behavior from ComboBox.
       aria-label="Clear"
+      data-testid="clear-button"
       onPress={() => {
         state?.setInputValue('');
         onClear?.();