Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow shell to be overridden #43

Closed
markbirbeck opened this issue Feb 13, 2015 · 1 comment
Closed

allow shell to be overridden #43

markbirbeck opened this issue Feb 13, 2015 · 1 comment

Comments

@markbirbeck
Copy link
Owner

It should be possible to use different shells to run commands, such as PowerShell on Windows.

@markbirbeck
Copy link
Owner Author

@mvoidex has proposed a nice solution at pull request #32. However, looking at it a bit more I think it's worth breaking the whole problem down a bit.

The solution provided by @mvoidex uses variable substitution into the command to allow extra characters to be added. However, Popen() already provides for an executable argument, so instead I'm going to allow that to be configured -- as step 1 -- and then provide another mechanism to add in the extra characters to the command.

markbirbeck added a commit that referenced this issue Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant