Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Taskbar icon #1570

Closed
Mr-McGregor opened this issue Jan 7, 2025 · 18 comments
Closed

[BUG]: Taskbar icon #1570

Mr-McGregor opened this issue Jan 7, 2025 · 18 comments
Assignees
Labels
Status-Fixed Ticket is resolved. Status-Not-Our-Bug Bug is present in some upstream libraries used by RSS Guard. Type-Defect This is BUG!!!

Comments

@Mr-McGregor
Copy link

Brief description of the feature request

Hello there!
Would it be possible to add an icon for the taskbar (screenshot of Ubuntu Budgie 24.04) ?
Thanks in advance.

taskbar-icon

@Mr-McGregor Mr-McGregor added the Type-Enhancement This is request for brand new feature. label Jan 7, 2025
@martinrotter
Copy link
Owner

RSS Guard has the taskbar icon. If it is missing, it could be packaging issue. Is this X11 or wayland?

@Mr-McGregor
Copy link
Author

Thanks for your quick response, Martin!

~$ echo "$XDG_SESSION_TYPE" x11

@martinrotter
Copy link
Owner

which file exactly did you install?

@Mr-McGregor
Copy link
Author

Flatpak.
RSS Guard io.github.martinrotter.rssguard 4.8.1

@martinrotter
Copy link
Owner

ok installing budgie/ubuntu in virtualbox

@Mr-McGregor
Copy link
Author

Thanks.
Install "AppIndicator Applet" from Budgie desktop settings > Panel > Applets.

@martinrotter
Copy link
Owner

martinrotter commented Jan 7, 2025

@guihkx Can you step in? I tried via ubuntu budgie with virtualbox, installed rssguard via flatpak.

Icon is really missing. Could it be the fact that the icon PNG file used for the tray icon is actually sandboxed away via flatpak and thus not physically available? Which is weird anyway because built-in icon from (lib)rssguard library is used, not an external icon file.

VirtualBox_manjaro_07_01_2025_09_25_59

@Mr-McGregor
Copy link
Author

What do you want me to do to help you?

@martinrotter
Copy link
Owner

I am not really sure. Because on other platforms, icon works. I believe it would also work when run from AppImage or installed deb package.

@martinrotter
Copy link
Owner

@Mr-McGregor Maybe if you could check some Budgie/ubuntu logs to see any warnings or errors when launching RSS Guard.

I checked RSS Guard logs themselves and do not see any weird errors related to tray icon.

@martinrotter
Copy link
Owner

@Mr-McGregor Also, I now installed official RSS Guard AppImage and that works flawlessly, even tray icon is properly displayed. This could be thus related to Flatpak somehow, @guihkx .

@martinrotter martinrotter added Status-Needs-Help Someone else must provide better info, testing or PR. Type-Defect This is BUG!!! and removed Type-Enhancement This is request for brand new feature. labels Jan 7, 2025
@martinrotter martinrotter changed the title [FR]: Taskbar icon [BUG]: Taskbar icon Jan 7, 2025
@guihkx
Copy link
Contributor

guihkx commented Jan 7, 2025

I'll set up Ubuntu Budgie on a virtual machine to investigate this.

However, I should note that I have no tray icon issues with the Flatpak package on Plasma 6.2.5:

image

@Mr-McGregor
Copy link
Author

With AppImage, it's perfect :

taskbar-icon

I had preferred to install RSS Guard in flatpak because Ubuntu 24.04 has quite a few problems with Appimages.
Sorry for the inconvenience and thanks again!

@martinrotter
Copy link
Owner

I'll set up Ubuntu Budgie on a virtual machine to investigate this.

However, I should note that I have no tray icon issues with the Flatpak package on Plasma 6.2.5:

image

Yes, it is entirely possible that this is purely budgie-specific thing as I remember trying on Plasma some weeks ago and it all worked fine there.

@Mr-McGregor
Copy link
Author

Maybe if you could check some Budgie/ubuntu logs to see any warnings or errors when launching RSS Guard.

Sorry, but you'd have to explain to me where I should look...

@guihkx
Copy link
Contributor

guihkx commented Jan 7, 2025

Okay, it took me a while to understand why the tray icon doesn't show up on Budgie when running through Flatpak.

In short, Budgie's tray icon applet (budgie-indicator-applet) relies on libayatana-appindicator to display the icon, but right now the latter lacks support for IconPixmap, which is what Qt mainly uses to set the icon.

And the reason why that works outside Flatpak, is because Qt also has a fallback mechanism, which creates a temporary PNG file "on disk" (it's actually created in /run/user/<UID>, which is technically still in RAM), and tells libayatana to use that instead of using the icon data in IconPixmap.

And by default, Qt doesn't apply that fallback mechanism when the app is running through Flatpak, hence the missing icon.

However, with the following (ugly) hack, you can force Qt to do that by pretending your desktop environment is Unity, i.e.:

flatpak run --env=XDG_CURRENT_DESKTOP=Unity io.github.martinrotter.rssguard

Please note that I haven't tested this long enough to make sure nothing else breaks.

But if having a proper tray icon is more important to you than that, and you want to make change that permanent, you can use a Flatpak override:

flatpak override --user --env=XDG_CURRENT_DESKTOP=Unity io.github.martinrotter.rssguard

I'm not sure if there's a less ugly solution to "fix" this at the moment.

@martinrotter
Copy link
Owner

That is perfect @guihkx I suspected something like that could be it, but my Flatpak knowledge is simply non-existent. Thus, thanks once more.

I close this but anyone feel free to add any comment you wish.

@martinrotter martinrotter added Status-Fixed Ticket is resolved. Status-Not-Our-Bug Bug is present in some upstream libraries used by RSS Guard. and removed Status-Needs-Help Someone else must provide better info, testing or PR. labels Jan 7, 2025
@Mr-McGregor
Copy link
Author

Thanks a lot @guihkx !
The workaround may be horrible, but it works.

It was just a detail, but I wanted to point it out.
And flatpak is better for me, the AppImages font is too small for my low vision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status-Fixed Ticket is resolved. Status-Not-Our-Bug Bug is present in some upstream libraries used by RSS Guard. Type-Defect This is BUG!!!
Projects
None yet
Development

No branches or pull requests

3 participants