Adreno activation incorrect location

[Tofee]

Hi,

I'm still trying to have the mainline kernel up and running on my Nexus5, but I have issues with the GPU that weren't there in v5.6.

While analyzing it, I found that this DTS patch seems incorrect:

nexus-5-upstream/out-of-tree-patches/upstream-patches/v5.16/0004-ARM-dts-qcom-msm8974-hammerhead-add-support-for-GPU.patch

Line 22 in 9987ee0

+ adreno@fdb00000 {

Indeed, the "gpu" node isn't located in the "otg" node, but in "soc". Or did I miss something?

[z3ntu]

This should become just

&gpu {
    status = "okay";
};

as now upstream for msm8974 the newer label style is getting used.

[masneyb]

Thanks for reporting this.

I tried running v5.19 on the phone and the upstream kernel still boots normally. The GPU is disabled upstream though for this phone. When I enable the GPU, ocmem fails to probe due to the following error: could not lock: -5 . That corresponds to -EIO. I tried adding the delay hack patch to clk-smd-rpm.c and still has an issue. I looked at this for about an hour today and I'm not really sure what's going on here unfortunately.

[z3ntu]

@masneyb Maybe you can try this branch,5.19-rc1? https://github.com/msm8974-mainline/linux/tree/qcom-msm8974-5.19.y

I'm quite sure GPU worked with that, I don't think I tested hammerhead though.

I'm also planning to rebase this branch to 5.19.1 once that becomes available.

[masneyb]

@z3ntu : OK, your tree was helpful. I was able to get the GPU working once I added your commit "Revert "drm/msm: Limit command submission when no IOMMU"". I pushed up a v5.19 patch set for the Nexus 5 to https://github.com/masneyb/nexus-5-upstream/tree/master/out-of-tree-patches/upstream-patches/v5.19:

• The first three patches are what's now required in order to get the GPU working
• The last three patches get the force feedback vibrator working. I think there's an unexpected issue with the clock duty cycle on msm8974 that I documented in the cover letter.

[Tofee]

@masneyb not sure I understand your last fix: I could get the UI working yesterday with https://github.com/Tofee/shr-linux/commits/hammerhead/5.19/mainline (5.19 + some patches)... what did it was a defconfig fix, I had to activate CONFIG_DRM_MSM_DP it seems.
I still have many gpu glitches with my Qt6 UI, but it mostly works.