Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neko - exceptions thrown by http.request not handled like other platforms #21

Open
misprintt opened this issue Jul 28, 2014 · 1 comment

Comments

@misprintt
Copy link
Contributor

Would there be a reason why HttpLoader on sys targets (e.g. neko) doesnt try to catch exceptions when triggering http.request() and pipe it through the loaderFail signal?

https://github.com/massiveinteractive/mloader/blob/master/src/mloader/HttpLoader.hx#L226

Other targets catch exceptions at this location correctly (e.g. js) - https://github.com/massiveinteractive/mloader/blob/master/src/mloader/HttpLoader.hx#L237

@dpeek
Copy link
Contributor

dpeek commented Jul 28, 2014

I don't think there's a particular reason for this, it's probably just an oversight. The only drawback would be that requests would fail silently unless you had a listener, but given that is the behaviour elsewhere I guess that's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants