Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK+-3: coco theme does not have round borders without compositor #98

Open
raveit65 opened this issue Feb 7, 2016 · 8 comments
Open
Milestone

Comments

@raveit65
Copy link
Member

raveit65 commented Feb 7, 2016

Coco theme does not have round borders without compositor.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30627214-gtk-3-coco-theme-does-not-have-round-borders-without-compositor?utm_campaign=plugin&utm_content=tracker%2F1172660&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1172660&utm_medium=issues&utm_source=github).
@raveit65 raveit65 added this to the Gtk+3 milestone Feb 7, 2016
@monsta
Copy link
Contributor

monsta commented Feb 12, 2016

I see that in my VM with 3.18 as well.

@raveit65 raveit65 changed the title GTK+-3.20: coco theme does not have round borders anymore GTK+-3: coco theme does not have round borders withoutcompositor Feb 13, 2016
@raveit65 raveit65 changed the title GTK+-3: coco theme does not have round borders withoutcompositor GTK+-3: coco theme does not have round borders without compositor Feb 13, 2016
@raveit65
Copy link
Member Author

You're right, i see that with gtk+-3.16 too.
But it works well if marco use compositor with all gtk+ versions.

@monsta
Copy link
Contributor

monsta commented Feb 15, 2016

Yes, same here. Looks like it started in 3.16 as I don't see this issue with 3.14.

@raveit65
Copy link
Member Author

Which m-n-d version are you using with gt+-3.14?
Maybe this is another result of infirits first re-work of m-n-d for gtk+-3 ?

@monsta
Copy link
Contributor

monsta commented Feb 15, 2016

Latest from git...

@monsta
Copy link
Contributor

monsta commented Feb 15, 2016

It seems that Coco actually has rounded borders, but w/o compositing, a black rectangle is painted around the notification window. Because Coco's background is black too, we see it as if the borders are not rounded. If you switch to Nodoka or Slider, you'll see the rounded corners and the black rectangle around the window.

@monsta
Copy link
Contributor

monsta commented May 21, 2016

So I thought it was happening only when the whole MATE is built with GTK+3... but it turned out it's not so. I've built the GTK+3 migration branch in GTK+2 environments with 3.16 and 3.18, and it still happens.

The issue looks similar to mate-desktop/marco#163, maybe they're related.

@lukefromdc: can you please take a look at both issues? Currently I have no idea how to fix them...

@lukefromdc
Copy link
Member

A transparent window is not possible without compositing with whatever
is underneath it. Round corners mean the drawn image is not using all
of the window, so without either a transparent window (composited) or
pseudotransparency(copying the background) you get black corners.

I know pseudotransparency using cairo drawing works in GTK3 because it
works for custom panel backgrounds with or without compositing. I don't
know Cairo well enough to code that for the notification daemon themes
though.

I've never once seen transparency in notification themes work without
composition in GTK3, so given that my GTK theme also requires it to work
with panel menus etc I had just considered this normal. This goes all the way
back to my first builds of 1.9, so my guess is that pseudotranparency code
used in GTK2 broke with the GTK3 transition.

Recall that in 1.9/1.10, most or all of the notification themes gave a totally
transparent background all the way across the notification window when
compositing was used or black if it was not. The contents of these windows
have mostly been fixed but evidenly the windows themselves have not been,

On 5/21/2016 at 9:31 AM, "monsta" [email protected] wrote:

So I thought it was happening only when the whole MATE is built
with GTK+3... but it turned out it's not so. I've built the GTK+3
migration branch in GTK+2 environments with 3.16 and 3.18, and it
still happens.

The issue looks similar to https://github.com/mate-
desktop/marco/issues/163, maybe they're related.

@lukefromdc: can you please take a look at both issues? Currently
I have no idea how to fix them...


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/mate-desktop/mate-notification-
daemon/issues/98#issuecomment-220777973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants