-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commander is outdated #299
Comments
I would post this in https://github.com/mateodelnorte/find-module-bin however based on the name I'm under assumption it is working as designed, finding the bin under the node_modules. |
My mistake, 1. turns out this was a commander issue and 2. it's actually resolved, my version of it was old, apologies. |
npm prefix -g
or npm bin -g
Actually it turns out this bug exists because commander is old |
Up for opening a pr? |
We have a forked version of commander - @mateodelnorte I know you made this commander fork but I am not clear on what the reason was for that or if the newest version of commander ever resolved this? https://github.com/mateodelnorte/meta/blob/master/package.json#L55 It's currently 594 commits behind mainline
If the mainline version of commander is still not adequate for what we need maybe there's another tool we could replace it with? |
Yeah, commander at some point made changes causing default behavior to no longer work. I created a PR to fix it and it went unmerged for ages, long enough for them to completely change their dev ethos around dependencies. Eventually they closed the PR. Unfortunate. |
There was some more conversation about this here in the past as well: #77 |
🐛 Bug Report
when I install a plugin meta can find the source of the plugin but not the bin.
To Reproduce
docker run -it node:18-bullseye /bin/bash
npm install -g meta
npm install -g meta-search
export DEBUG=*
meta search
Expected behavior
meta-search
directlyresolve
because find-module-bin does not look for a bin dir within either
npm prefix -g
ornpm bin -g
the bin file for meta search isn't foundsymlinking it into one of the dir's it is checking, resolves the issue
The text was updated successfully, but these errors were encountered: