Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axes toggle on Visualisation doesn't appear to work. #198

Closed
CompRhys opened this issue Jun 15, 2021 · 4 comments
Closed

Axes toggle on Visualisation doesn't appear to work. #198

CompRhys opened this issue Jun 15, 2021 · 4 comments
Labels

Comments

@CompRhys
Copy link

I would assume the axes toggle is supposed to turn off the axes indicator in the bottom corner but this doesn't appear to be the case.

image
image

@mkhorton
Copy link
Member

This is true. Some axes functionality broke when we separated the axes out from being part of the scene to being pinned in the corner. Note the deployed version of this app is from last July, there's been a lot of work done in the main branch since then.

However, this code is still not technically released or intended for external use yet, there is no associated publication, tests are still failing, etc. It's being developed in the open but your mileage may vary :-)

By all means send me an email if you want to start using it and have questions.

@CompRhys
Copy link
Author

Ahh okay, I don't think I am the target user here in terms of what the app offers. I was simply looking for a quick way to get high-ish res structure renders for a presentation. Whenever I use Vesta I always seem to get really poor looking structures with super shiny surfaces and pixelated lines.

Along the directions above it would be great to be able to vary the camera position numerically but I am not sure how easy it could be implemented

@mkhorton
Copy link
Member

Ah fair enough. It's decent enough for this, but not as user friendly as it could be right now.

One of the design goals of Crystal Toolkit was to give faithful representations of pymatgen objects, e.g. if you have a specify set of bonds you want to display, or color-code by a specific site property etc. The rendering quality is somewhat improved, but VESTA is more performant.

For visualization purposes, one of the nice aspects of Crystal Toolkit is the Jupyter integration, when you have a visualization you like it can be saved to JSON (.ctk.json), to open up separately later within Jupyter.

@mkhorton
Copy link
Member

Also just to add -- the app itself, app.crystaltoolkit.org, is intended as a demo of the framework, not the end product in and of itself.

@mkhorton mkhorton added the bug label Jul 18, 2022
@CompRhys CompRhys closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants