Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Question Titles Using Query #66

Open
3 tasks done
noce2 opened this issue Sep 27, 2020 · 1 comment · Fixed by #69
Open
3 tasks done

Validate Question Titles Using Query #66

noce2 opened this issue Sep 27, 2020 · 1 comment · Fixed by #69
Assignees
Labels
1 day Task should take a day bug Something isn't working

Comments

@noce2
Copy link
Contributor

noce2 commented Sep 27, 2020

Validation of question titles in the Question Authoring page performs a GET request for a question of some title. If a 404 is returned, the Question Title Validator indicates the question is valid and allows a user to proceed. The problem with this is that all 404s register SEVERE errors in the Chrome Browser console (might do the same in other browsers) which causes e2e tests to fail (because they assert no server logs are present).

The scope of this issue is to modify the validation of a question title to use a search query as described here: https://github.com/math-dojo/question-service/blob/f844c71837f605aa2fa012aed58d27f549d1ab0b/openapi.yaml#L126

Acceptance Criteria:

  • A new method for searching for questions based on their title is created in the Question Service
  • The validator is modified to return a validation response based on whether matching results are found in the array of QuestionDtos
  • The line in the question authoring e2e test for sanitising logs is removed.
@noce2 noce2 added bug Something isn't working 1 day Task should take a day labels Sep 27, 2020
@noce2 noce2 self-assigned this Sep 29, 2020
@noce2
Copy link
Contributor Author

noce2 commented Sep 29, 2020

Will be resolved by #69

@noce2 noce2 linked a pull request Sep 30, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 day Task should take a day bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant