Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total startup time can be unpredictable when doing full restarts, mark bridge as "up" when initial configuration checks pass #1762

Open
Half-Shot opened this issue Jul 31, 2023 · 1 comment
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@Half-Shot
Copy link
Contributor

For larger deployments, we often need to do quite a bit of work before the bridge is fully "up". Rather than having the liveness probe fail until everything is ready, it's easier to move the probe so that we report ready when the bridge has reached it's dependencies (homeserver, db, redis etc).

@Half-Shot Half-Shot added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jul 31, 2023
@Half-Shot
Copy link
Contributor Author

Hm, this is potentially wrong. We actually respond to /health with an OK as soon as we've done the initial checks, as health is available as soon as the listener has started. I am unsure why the health checks were failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Development

No branches or pull requests

1 participant