Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky jest test: Room › recalculate › recalculates in acceptable time without heroes #4331

Closed
richvdh opened this issue Jul 29, 2024 · 2 comments · Fixed by #4332
Closed

Flaky jest test: Room › recalculate › recalculates in acceptable time without heroes #4331

richvdh opened this issue Jul 29, 2024 · 2 comments · Fixed by #4332
Assignees
@t3chguy
Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Jul 29, 2024 

  FAIL  spec/unit/room.spec.ts (44.217 s)
  ● Room › recalculate › recalculates in acceptable time without heroes

    expect(received).toBeLessThan(expected)

    Expected: < 200
    Received:   201.00067000000126

      1409 |             }
      1410 |             const duration = performance.now() - start;
    > 1411 |             expect(duration).toBeLessThan(200);
           |                              ^
      1412 |         });
      1413 |     });
      1414 |

      at Object.toBeLessThan (spec/unit/room.spec.ts:1411:30)

https://github.com/matrix-org/matrix-js-sdk/actions/runs/10141777398/job/28039689995?pr=4310#step:6:3564
@richvdh richvdh mentioned this issue Jul 29, 2024
Closed
@richvdh
Copy link
Member Author

richvdh commented Jul 29, 2024

Also https://github.com/matrix-org/matrix-js-sdk/actions/runs/10143074774/job/28043693536#step:6:3430

@dosubot dosubot bot added A-Testing Testing, code coverage, etc. T-Defect labels Jul 29, 2024
@t3chguy t3chguy self-assigned this Jul 29, 2024
t3chguy added a commit that referenced this issue Jul 29, 2024
@t3chguy
Remove flaky test
01d2774 
Fixes #4331
@t3chguy t3chguy mentioned this issue Jul 29, 2024
Merged
4 tasks
@richvdh richvdh added A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jul 29, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 29, 2024
@t3chguy
Remove flaky test (#4332)
0300d63 
Fixes #4331
@richvdh
Copy link
Member Author

richvdh commented Jul 29, 2024

thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove flaky test matrix-org/matrix-js-sdk
2 participants
@richvdh @t3chguy