You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The text was updated successfully, but these errors were encountered:
zeronumbers
changed the title
Misleading parameter name in type of message#channel handler (MessageEventIndex in ClientEvents)
Misleading parameter name in type of message#channel handler (MessageEventIndex in ClientEvents) also part#channel is wrong
May 2, 2024
https://github.com/matrix-org/node-irc/blob/master/src/events.ts#L62
I believe
who
parameter should be namedtext
since it actually holds string that nick sends.https://node-irc.readthedocs.io/en/latest/API.html#'message#channel'
Shows that it should be text.
the actual code uses text as well:
https://github.com/matrix-org/node-irc/blob/master/src/irc.ts#L885
the part#message is also wrong:
who
is actuallyreason
https://node-irc.readthedocs.io/en/latest/API.html#'part#channel'
The text was updated successfully, but these errors were encountered: