Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete ExperimentalTransitRoute if possible #3349

Closed
paulheinr opened this issue Jul 1, 2024 · 3 comments
Closed

Delete ExperimentalTransitRoute if possible #3349

paulheinr opened this issue Jul 1, 2024 · 3 comments
Assignees
Labels
maintenance things that should be done to improve code and UI

Comments

@paulheinr
Copy link
Contributor

paulheinr commented Jul 1, 2024

Since it is marked as deprecated and pollutes code, it should be deleted if possible
org.matsim.pt.routes.ExperimentalTransitRoute

It is replaced in PersonPrepareForSim with a DefaultTransitPassengerRoute

@paulheinr paulheinr added the maintenance things that should be done to improve code and UI label Aug 9, 2024
@vsp-gleich vsp-gleich self-assigned this Nov 4, 2024
@vsp-gleich
Copy link
Contributor

What do we do with the conversion in PersonPrepareForSim? I would suggest to keep it for backward compatibility. So I will try to delete the other occurences, right?

@paulheinr
Copy link
Contributor Author

It is deprecated since 2020. So I would say, it's totally fine that the phase of backward compatibility is over.

@vsp-gleich
Copy link
Contributor

To me it seems all occurences of org.matsim.pt.routes.ExperimentalTransitRoute are needed to read in an old plans file with ExperimentalTransitRoute and have it converted to DefaultTransitPassengerRoute. That means we can either remove that backward compatibilty or there is nothing to be done.

@vsp-gleich vsp-gleich moved this from Todo to To Be Reported in MATSIM advanced weekly hackathon Nov 4, 2024
@vsp-gleich vsp-gleich closed this as completed by moving to To Be Reported in MATSIM advanced weekly hackathon Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance things that should be done to improve code and UI
Projects
Development

No branches or pull requests

2 participants