Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename things in CarrierService / CarrierShipment, to have this consistent. #3509

Closed
kt86 opened this issue Oct 10, 2024 · 3 comments · Fixed by #3645
Closed

Rename things in CarrierService / CarrierShipment, to have this consistent. #3509

kt86 opened this issue Oct 10, 2024 · 3 comments · Fixed by #3645
Assignees

Comments

@kt86
Copy link
Contributor

kt86 commented Oct 10, 2024

Also adapt the fields in the xml file as well.

This is a first step on the way to maybe introduce something lika a "CarrierJob" on MATSim-level, which can have 1 or 2 locations. If it is a 1-location job, jsprit uses "Services", if it has 2 locations, it uses "Shipments".

@kt86 kt86 converted this from a draft issue Oct 10, 2024
@kt86 kt86 changed the title Rename things in CarrierService / CarrierShipment, to have this consitent. Also adapt the fields in the xml file as well. This is a first step on the way to maybe introduce something lika a "CarrierJob" on MATSim-level, which can have 1 or 2 locations. If it is a 1-location job, jsprit uses "Services", if it has 2 locations, it uses "Shipments". Rename things in CarrierService / CarrierShipment, to have this consitent. Oct 10, 2024
@kt86 kt86 moved this from Todo (high priority) to Todo (low priority) in MATSIM advanced weekly hackathon Nov 18, 2024
@kt86
Copy link
Contributor Author

kt86 commented Nov 18, 2024

This will lead in the end to a new carrierDefinition XSD... because we will also update the names in the xml file.

@rewertvsp
Copy link
Contributor

  • einheitliche Benennung zwischen Service und Shipment (z.B. TimeWindows, Demand/Size...)

@kt86
Copy link
Contributor Author

kt86 commented Nov 25, 2024

Let's do matsim-vsp/logistics#314 first, so we have all changes in one repo/PR...

@kt86 kt86 changed the title Rename things in CarrierService / CarrierShipment, to have this consitent. Rename things in CarrierService / CarrierShipment, to have this consistent. Dec 3, 2024
@kt86 kt86 moved this from Todo (low priority) to To Be Reported in MATSIM advanced weekly hackathon Dec 20, 2024
@kt86 kt86 moved this from To Be Reported to Done in MATSIM advanced weekly hackathon Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants