Freight (logistics): Confusion re deliveryTime for CollectionCarrier.

[kt86]

From @JWJoubert:
We found it a bit counter-intuitive (it took us some time to pinpoint the discrepancy) that for the LspShipment, the “collection” or pick-up time, the code uses the “delivery time”, even though the LspShipment does have a “pickupServiceTime” option.

From my first view on it, this seems to be wrong in the code, so that in https://github.com/matsim-vsp/logistics/blob/c9316926ab46b31254f24fb80ff8dc1197d8e244/src/main/java/org/matsim/freight/logistics/resourceImplementations/CollectionCarrierScheduler.java#L89 and https://github.com/matsim-vsp/logistics/blob/c9316926ab46b31254f24fb80ff8dc1197d8e244/src/main/java/org/matsim/freight/logistics/resourceImplementations/CollectionCarrierScheduler.java#L137 (?) it should use get**Pickup**...

Just changing the code will cause a lot of test failures (which is somehow, good, showing, that this is tested)

((The logistics repo goes into archive mode, code is not on matims-libs. So the issue is moved from - see there for more information: matsim-vsp/logistics#334 ))