Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for inlining Signature for #622

Open
thomas-lamiaux opened this issue Oct 8, 2024 · 4 comments
Open

Warning for inlining Signature for #622

thomas-lamiaux opened this issue Oct 8, 2024 · 4 comments

Comments

@thomas-lamiaux
Copy link
Contributor

A warning

Automatically inlined signature for type vec. Use [Derive Signature for vec.] to avoid this.

Is triggered when deriving NoConfusionHom but not when deriving NoConfusion.
I would have expected the opposite.

Further, is there even a need for a warning ? I would expect users not to have to derive Signature as it exposes the internal interface which users should not have to care about ?

@TheoWinterhalter
Copy link

Well if it inlines it, then it might end up doing so several time, which would be inefficient I think. Hence why it asks the user to derive the signature once and for all? If it could be a quickfix then all would be good no?

@thomas-lamiaux
Copy link
Contributor Author

thomas-lamiaux commented Oct 9, 2024

That could work, but why can't Derive NoConfusion = Derive NoConfusion + Signature ?
(you only need to derive it once, right ?)

@TheoWinterhalter
Copy link

My guess would be that this way you know that this is a side effect of NoConfusion so that you don't also Derive Signature later. It becomes a bit more predictable what is happening and when.

@thomas-lamiaux
Copy link
Contributor Author

It but my point is should the user be allowed to derive signature at all ? Shouldn't it be done automatically ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants