Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR: Unsupported architecture detected! #519

Closed
pattool opened this issue Jan 8, 2025 Β· 4 comments Β· Fixed by #523
Closed

ERROR: Unsupported architecture detected! #519

pattool opened this issue Jan 8, 2025 Β· 4 comments Β· Fixed by #523
Assignees

Comments

@pattool
Copy link

pattool commented Jan 8, 2025

πŸ› Bug Report for anvil-zksync

πŸ“ Description

Trying to do the installation anvil-zksync I am running with an ERROR: Unsupported architecture detected!.

πŸ–₯️ Environment

  • Working on a mini mac 1 2018
  • x86_64 Macs.
  • Mac OS 15.2

πŸ“Ž Log Output

ERROR: Unsupported architecture detected!
@itegulov
Copy link
Contributor

itegulov commented Jan 8, 2025

Hmm, I think this might be because our cargo-cross release pipeline is misconfigured:

[cross] warning: `cross` does not provide a Docker image for target x86_64-apple-darwin, specify a custom image in `Cross.toml`.
[cross] note: Falling back to `cargo` on the host.

So essentially we just build arm64 binary twice.

Most likely we just need to not run cargo-cross for macOS targets and instead rely on host's cargo and then just change x86_64 macOS image to macos-latest-large (for some reason that's what Github decided to call x86_64 images - ref).

CC @dutterbutter @Romsters @popzxc

@dutterbutter dutterbutter self-assigned this Jan 8, 2025
@dutterbutter
Copy link
Collaborator

dutterbutter commented Jan 8, 2025 β€’

@itegulov I dont think its an issue with x86_64 binary. The host it falls back on is correctly 'x86_64-apple-darwin' and if we inspect the binaries from the release:

# file ./anvil-zksync
Mach-O 64-bit executable x86_64
# lipo -info ./anvil-zksync
Non-fat file: ./anvil-zksync is architecture: x86_64

The issue seems to be in the installation script. I will proceed to further investigate / update. I know it will fail if user is using rosetta as the architecture detected will be i386 which we dont have a case for. I will update it to make use of x86 if rosetta is detected but will still need to test on x86 machine.

With that I am going to continue with v0.2.2 release as this seems non-blocking.

@dutterbutter
Copy link
Collaborator

Confirmed worked for apple x86 with #523

@itegulov
Copy link
Contributor

itegulov commented Jan 9, 2025

@pattool the issue should be resolved now. Could you try running the installation script again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants