Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/servicenow subscriptions add is not opening the modal as expected #140

Closed
DHaussermann opened this issue Dec 8, 2022 · 8 comments
Closed
Assignees
Labels
Type/Bug Something isn't working

Comments

@DHaussermann
Copy link

DHaussermann commented Dec 8, 2022

There seems to be an issue on some servers where the modal for adding a subscription will not open. Nothing happens when you run the slash command. I see nothing relevant in browser dev logs or console logs.

The modal does open with the Add New subscription button.

Modal.open.issue.mov
  • This occurs on a cloud server I have running 5.37.3 I do not see the same issue occur locally.
  • Both servers are running the v2.3.3 build from the version bump PR in this repo.
  • This occurs in all browsers and the desktop client.
@DHaussermann DHaussermann added Type/Bug Something isn't working Triage labels Dec 8, 2022
@ayusht2810
Copy link
Contributor

@DHaussermann this issue will be fixed with issue #120

@DHaussermann
Copy link
Author

@ayusht2810 are you able to provide some context on why my other server is not affected?

Was it possible to open a modal with the command on earlier builds before v2.3.3?

@DHaussermann
Copy link
Author

@ayusht2810 after discussing this issue it could be lower in priority however on the 5.37 server in the video - There is no button to add additional subscriptions beyond the 1st once 1 is created.
image

This also does not repro on my local. Ping me if it helps to send an invite to the affected server. Also happy to open a separate issue here if neded.

@DHaussermann
Copy link
Author

DHaussermann commented Dec 12, 2022

@ayusht2810 I also see this issue on the Add and Update buttons can you see if this is the same problem

If it helps you can use this link https://dkh-5-37.test.mattermost.cloud/signup_user_complete/?id=6ukd7r1ubtni8qysx3ho59gx3o

image

@ayusht2810
Copy link
Contributor

@DHaussermann this issue is fixed in the PR #141

@ayusht2810
Copy link
Contributor

@DHaussermann These are fixed so please verify and close

@ayusht2810
Copy link
Contributor

@DHaussermann reminder to verify the issue.

@raghavaggarwal2308
Copy link
Contributor

raghavaggarwal2308 commented Mar 13, 2024

@ayusht2810 Verified, the above issue are fixed now.

Tested on MM cloud server version v6.3.0 with master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants