Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MP4 / iOS Live Photos #26

Open
JakeAi opened this issue Feb 8, 2022 · 0 comments
Open

Support MP4 / iOS Live Photos #26

JakeAi opened this issue Feb 8, 2022 · 0 comments

Comments

@JakeAi
Copy link

JakeAi commented Feb 8, 2022

In the file get-companion-json-path-for-media-file.ts you can add the following

  // Edge case where google/iOS creates a thumbnail as a JPG for an MP4 and saves it in a json sidecar possible for iOS Live Photos
  if (mediaFileExtension === '.MP4' || mediaFileExtension === '.mp4') {
    potentialJsonFileNames.push(`${mediaFileNameWithoutExtension}.JPG.json`);
    potentialJsonFileNames.push(`${mediaFileNameWithoutExtension}.jpg.json`);
  }
@JakeAi JakeAi changed the title Support MP4 Support MP4 / iOS Live Photos Feb 8, 2022
arewm added a commit to arewm/google-photos-exif that referenced this issue Oct 15, 2022
Edge cases included:
* .mp4 can use jpec and heic json files: mattwilson1024#26
* Counters may collide with other rules
* Long filenames are truncated: mattwilson1024#28
* Some json files have .j and .jp as the media extension

Signed-off-by: arewm <[email protected]>
arewm added a commit to arewm/google-photos-exif that referenced this issue Oct 15, 2022
Edge cases included:
* `.mp4 can use jpeg and heic json files: mattwilson1024#26
* Counters may collide with other rules
* Long filenames are truncated: mattwilson1024#28
* Some json files have `.j` and `.jp` as the media extension

Signed-off-by: arewm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant