-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Help wanted!) More and more tests! #36
Comments
The |
I have a question, Map<Character, List<Integer>> byAlphabet =
aList.stream()
.collect(
Collectors.groupingBy(
e -> new Character(e.getName().charAt(0)),
Collectors.mapping(Avatar::getId, Collectors.toList()))); For example, that's stream above, there is a method reference, but currently RFC does not include it. So, the result of RFC metric above is 7, what should be the result 7 or 8? |
We are probably not counting the Avatar::getId, but maybe we should! Would you mind fixing it and opening a PR? |
Sure!I opened up a pull request |
CK is a simple tool; yet, people's code are complicated!! Although our test suite has been growing, there are always exceptional cases that might lead the tool to bring strange results.
If you are looking for a way to start contributing to this project, I suggest you to write tests!! Our test suite is full of examples! In practice, all you need to do is:
/fixture
folderSubmit your tests as a PR!
If you found a bug,** THANK YOU**! Feel free to fix it yourself! If you can't, no worries. Just open an issue, and I'll work on that!
The text was updated successfully, but these errors were encountered: