Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Action components generic #135

Closed
pastpatryk opened this issue May 5, 2020 · 1 comment · Fixed by #327
Closed

Make Action components generic #135

pastpatryk opened this issue May 5, 2020 · 1 comment · Fixed by #327
Labels
enhancement New feature or request

Comments

@pastpatryk
Copy link
Member

Action components are not generic. They are tight to specific implementation and even translations of Kalambury game. If we want to add more games we need to make them generic like message image success error etc.
@pastpatryk pastpatryk added the enhancement New feature or request label May 5, 2020
@glowacki-dev
Copy link
Member

glowacki-dev commented May 5, 2020 •
edited
Loading

There is a broader issue already #111 because GameContext is kalambury-specific as well 😞

@pastpatryk pastpatryk mentioned this issue Apr 29, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor sidebar actions mavend/octoboard
2 participants
@pastpatryk @glowacki-dev