Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing on larger designs #77

Open
lindehell opened this issue Jun 2, 2021 · 11 comments
Open

Crashing on larger designs #77

lindehell opened this issue Jun 2, 2021 · 11 comments
Labels

Comments

@lindehell
Copy link

When I try to make a 6x6 board midibead or a 4x4 mini the interface crashes. I always used it on my mobile and it never used to be a problem. It says "WebGL not available on this browser". I tried other browsers and still the same.
Screenshot_20210602-162004

I run Android 11 on a Samsung A71.

@maxcleme
Copy link
Owner

maxcleme commented Jun 2, 2021

@lindehell

Hi, thanks for submitting such bug.

Is there any way you could answer the following question in order to better understand/reproduce the issue :

  • Does it also happen with smaller image ? Other board configuration ? Or does it always happen ?
  • Does it also happen on desktop with the same image ?
  • Which other browsers, versions did you use ?
  • Which Chrome version it is ?
  • Can you submit the image here ?

@maxcleme maxcleme added the bug label Jun 2, 2021
@lindehell
Copy link
Author

It always happens when I go large enough. Doesn't matter what photo it is. 6x6 boards seem to be the critical size when it happens. 5x7 works but haven't played around with it. It happens regards of palette.

I mostly use Chrome and it's now v91.0 but it auto updates.

It actually works in Firefox 89.1.1 so I might migrate over there for pattern making.

It does not happen on the desktop/laptop. Only phone

@maxcleme
Copy link
Owner

maxcleme commented Jun 8, 2021

@lindehell

Thanks for update,

I'll see what I can do once I got a bit of free time and I'll get back to you.

I think I have some insights about what could leads to this, but I have to confirm everything first.

@maxcleme
Copy link
Owner

maxcleme commented Jun 8, 2021

@lindehell

As I though, it seems to be related to rendering only when the scaling is too small and goes beyond sub pixels. It is really weird since it works fine for ages but I guess standards and specifications also change from time to time.

My current workaround is as follows :

  • Apply minimum scaling factor for the rendering preview (currently set a 0.2)
  • Implement scrollbar when factor should theoretically goes below 0.2

Changes are currently building, I'll ping you as soon as new version is available to check it out.

@maxcleme
Copy link
Owner

maxcleme commented Jun 8, 2021

@lindehell

Should be fixed in 1.27.0.

May I ask you to double check if everything is fine on your side ? (Be aware of cache, might be worth it to try it out in incognito mode).

@lindehell
Copy link
Author

Good news and bad news:

The good: it now works for 6x6 (in incognito mode)

The bad: It crashes when I try changing palette, which is what I mostly use. Same error message

The ugly: Now I cannot load a picture in Firefox. When I pick one it just refreshes the site which brings me back the the "Select Image..." box. I'll try and se if it works if I use a third party file browser.

@lindehell
Copy link
Author

Disregard the ugly. I got it working by reinstalling Firefox

@maxcleme
Copy link
Owner

maxcleme commented Jun 9, 2021

@lindehell

May I ask you to explain step by step how to reproduce the issue ? With the initial image if not sensitive ?

I tried to change palette on big picture / small picture / many boards, but it seems I'm unable to reproduce the issue.

@lindehell
Copy link
Author

Sorry for the late answer.

I after I pick the picture (any picture), I set the width to six 29×29 boards and then the height. This works untill 5 boards in height but when I reach six the pattern disappear and when I make any one adjustment after that (palette, image settings etc.) it crashes.

In a past version the pattern disappeared at this size too but turning the phone horizontal solved that.

@maxcleme
Copy link
Owner

maxcleme commented Jun 19, 2021 via email

@lindehell
Copy link
Author

The resolution of the picture I last used (but all pictures fail at 6x6 or above) is 2048x2036, filetype is .jpeg

Both portrait and landscape fail when reaching the critical size. Before portrait couldn't show the pattern but it became visible when tilting to landscape

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants