Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation messages #69

Open
AntseN opened this issue Dec 3, 2019 · 1 comment
Open

Fix deprecation messages #69

AntseN opened this issue Dec 3, 2019 · 1 comment

Comments

@AntseN
Copy link

AntseN commented Dec 3, 2019

First of all thanks for this bundle.
Since symfony 5 is out, it would be great to fix the deprecation messages coming from this bundle :

The "Mgilet\NotificationBundle\Controller\NotificationController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.

Which shouldnt be too hard to fix ^^

@maximilienGilet
Copy link
Owner

Hi, thanks for the tip-off,

Unfortunately I don't use the bundle anymore, so feel free to create a pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants